trackslash
VAULT-16 P2

Try the new create/edit sheets and decrypt animation on a device

0
All issues

Description

Sprint 1 was checked in the simulator and with snapshot tests only. These two changes depend on animation, sheet sizing and the keyboard, so they're worth trying on a real phone:

  • Create/edit flow (VAULT-9, #606):
    • Create each item type (code by scan and by manual entry, note, recovery phrase).
    • Check that each step's sheet resizes smoothly, the keyboard doesn't cover fields, and slide transitions look right.
    • Edit an existing item from the overview, jumping straight to each step.
    • Try large text sizes and VoiceOver.
  • Decrypt animation (VAULT-8, #601):
    • Unlock an encrypted item with the right password to see the door animation.
    • Use a wrong password to see the shake and the red error cell.
    • Try with Reduce Motion both on and off.

File anything that looks off as its own issue.

Linked issues

2
Relates to VAULT-9 P2 Rework item create/edit flow (all item types) Done
Relates to VAULT-8 P2 Encrypted item decryption: unlock-style animation and prominent wrong-password error Done

Sub-issues

0

GitHub

0

No branches or pull requests linked.

Comments

1
Bradley

Checked in the simulator instead of on a device, as Bradley decided, on a build of main at b2d4d400. That build includes VAULT-28's single create sheet. Screenshots, videos and frame strips are in ~/Library/Caches/vault-sprint2/qa/VAULT-16/ on the Mac Studio.

Create and edit flow (VAULT-9 / VAULT-28):

  • Creating each type: pass. This covered a code by simulated scan and by setup key, a note, and a 12-word recovery phrase with a password.
    • The type step is part of the sheet, and Back returns to it with a slide.
    • Sheets resize smoothly, and slide transitions look right in the recorded frames.
  • Editing from the overview: pass. Jumping to Name, Appearance and Privacy, then saving, works.
  • Large text:
    • xxLarge: pass.
    • The largest accessibility size (AX5) is usable but poor. It's filed as VAULT-67.
  • VoiceOver: checked through the accessibility tree.
    • Steps expose "Step N of M", headings, switches with values, and combined card labels: mostly pass.
    • LabeledTextField inputs have no accessibility label. This is filed as VAULT-66.
  • Dark mode: pass.

Decrypt animation (VAULT-8):

  • Reduce Motion off: pass. The wheel turns, the door swings open, and the item opens. A wrong password shows the red flood, the rattle and white text, and editing the password drains it.
    • In light mode, the cell is blank for about 5 frames before the flood. This is filed as VAULT-68.
  • Reduce Motion on: pass. The red cell appears at once with no rattle, the item opens at once, and steps cross-fade.

Found, and filed:

  • VAULT-65 (this sprint): rows that open a sheet (Tags, Encryption, Password) ignore the first tap after changing step.
  • VAULT-66 (this sprint): the editor's text fields have no accessibility labels.
  • VAULT-67 (backlog): the editor and feed at AX5.
  • VAULT-68 (backlog): the light-mode flash.

Not covered by the simulator:

  • whether the software keyboard covers fields, since the simulator only ran with a hardware keyboard
  • real VoiceOver navigation and announcements
  • haptics
  • a real camera scan
  • 120 Hz smoothness and real-finger sheet gestures