trackslash
VAULT-94 P2

Remove the "Type" header from the New Item sheet

0
All issues

Description

The first step of the New Item sheet (CreateItemPickerView) opens with a step header: a plus icon, the title "Type", and "Choose what kind of item to add to your vault." It adds nothing. The navigation title already says "New Item", and the Code / Note / Recovery Phrase cards below it speak for themselves.

Change

  • Remove the DetailEditorStepHeader section from CreateItemPickerView, so the sheet goes straight to the three option cards under the "New Item" title.
  • Check the sheet still sizes to fit (reportsFittedSheetHeight()), with sensible top spacing above the first card, and that picking an item still slides on to its first step.
  • Update the view's doc comment, which describes it as "with a step header".

Done when

  • The header is gone, and the sheet looks right in light and dark.
  • CreateItemPickerViewSnapshotTests are re-recorded.

Sub-issues

0

Linked issues

0

GitHub

0

No branches or pull requests linked.

Comments

1
Bradley

Fixed in https://github.com/badbundle/vault-app/pull/704 (merged as 1b031c7e).

The New Item sheet now opens straight on the Code, Note and Recovery Phrase cards under its "New Item" title. The DetailEditorStepHeader section is gone from CreateItemPickerView, and its doc comment says why. Checked in the simulator: the sheet still fits its three cards, with the form's usual spacing under the title, and picking Note still slides on to its first step. CreateItemPickerViewSnapshotTests were re-recorded (light and dark, four text sizes), and the CHANGELOG line was updated. make validate passed.