trackslash
VAULT-68 P2

The wrong-password cell goes blank for a moment before turning red in light mode

0
All issues

Description

Found while testing VAULT-16 (the decrypt animation from VAULT-8, #601).

The glitch: in light mode, when a wrong password is entered for an encrypted item, the text and door glyph turn white before the red flood starts. For about 5 frames, the cell looks blank: white on a light background. Dark mode and Reduce Motion are fine.

Evidence: frames 05b/05c in ~/Library/Caches/vault-sprint2/qa/VAULT-16/ on the Mac Studio.

Fix: delay the white foreground until the flood covers the cell, or mask it with the flood's progress.

Sub-issues

0

Linked issues

0

GitHub

0

No branches or pull requests linked.

Comments

1
Bradley

Fixed in https://github.com/badbundle/vault-app/pull/661 (merged as 40d344be).

The fix: the header is now drawn twice, as usual outside the flood and in white inside it, masked by the same animated circle as the red. The red moved from the row's background into the row itself, because as a background it started a few frames after the text turned white. So the text reads dark until the red reaches it and white from then on, and the same in reverse as the red drains. The white copy's door runs the same rattle but never clicks, clears the rattle, or opens the item.

Also fixed: the old code centred the flood 4 pt off the door, because it assumed an 11 pt row inset; the real default is 15.

Testing:

  • I recorded a wrong password and the drain at 60 fps in the Simulator, in light mode. There's no blank frame, and the text turns white exactly where the red covers it. The right password still opens the note once.
  • Frame sheets and videos are in ~/Library/Caches/vault-backlog-qa/VAULT-68/.
  • The flooded "Incorrect Password" snapshots pass unchanged.