trackslash
VAULT-53 P2

Keep QuickType and note preview choices when restoring a backup

0
All issues

Description

Found in the VAULT-26 study: the backup format drops two fields, showInQuickType and previewMode.

Effect of restoring a backup:

  • QuickType turns back on for every item the user had opted out of, which goes against MANIFESTO.md C7.
  • Note preview modes reset.

What to change:

  • Add both fields to VaultBackupItem as optional.
  • When a field is missing from an older backup, fall back to what restore does today.
  • Make sure exports and device transfer carry both fields too.

Tests: round trips with the new fields, and decoding older backups that don't have them.

Sub-issues

0

Linked issues

0

GitHub

0

No branches or pull requests linked.

Comments

1
Bradley

Fixed in https://github.com/badbundle/vault-app/pull/624 (merged as 40744d42).

  • Backup format: VaultBackupItem now carries two optional fields, showInQuickType and previewMode (stored as TITLE_AND_FIRST_LINE, TITLE_ONLY or HIDDEN). The encoder writes them for PDF export, device transfer and auto-backup.
  • Restoring: the decoder restores both fields. For backups made before this change, it falls back to the old defaults (QuickType on, title and first line).
  • Compatibility: no format version bump was needed. Older app versions ignore the new keys.
  • Tests: a JSON snapshot pins the wire format, and there are encoder and decoder tests. A full PDF round trip, for both merge and override imports, checks that an opted-out code stays out of QuickType and that note preview modes survive (MANIFESTO C7).