trackslash
VAULT-37 P2

Let people choose what tapping a code does

0
All issues

Description

Add a "Tap a Code To" setting, with Copy (the default, and today's behavior) or Show Details.

Today:

  • Tapping a card in the feed runs its preview action (VaultListView.interactableViewGenerator()). For codes, that copies the code, asking for authentication first if the item is locked.
  • In edit mode, tapping opens the item instead.

Details:

  • With Show Details, tapping a code opens its detail page. Copying must still be one step away, for example from the card's context menu (check one exists).
  • Locked items still need authentication to copy.
  • Edit mode and AutoFill (where tapping picks the code) are unchanged.

Tests: unit tests for both settings, in and out of edit mode, including for locked items.

Sub-issues

0

Linked issues

0

GitHub

0

No branches or pull requests linked.

Comments

1
Bradley

Fixed in https://github.com/badbundle/vault-app/pull/632 (merged as 30242338).

The setting: a new Tap a Code To setting, with Copy (the default, and today's behaviour) or Show Details. It sits in a new Codes section in Settings, with a teal icon. The sections now run Security, Screen Recording, Codes, New Items, Clipboard, Danger Zone.

Copying stays one step away:

  • Every code now has a touch-and-hold context menu with Copy Code and Show Details, whichever the setting is. Both are also VoiceOver actions.
  • The code is worked out when Copy Code is chosen, so a code that rolled over while the menu was open is copied as it is now.

Locked items:

  • Copying still needs authentication, from a tap or from the menu.
  • With Show Details, tapping opens the detail page, which has its own lock screen.

Unchanged:

  • Notes and other items with nothing to copy.
  • Edit mode: tap to edit, no menu, and drag to reorder still works.
  • AutoFill.

Implementation: VaultItemTapHandler now makes the tap decision that used to sit in VaultListView, so it's unit tested. VaultItemMenuDecoratorViewGenerator adds the menu.

Tests:

  • VaultItemTapHandlerTests (16) cover both settings, in and out of edit mode, locked items and authentication failures.
  • There are settings persistence tests.
  • The Settings snapshots were re-recorded for the new section.