trackslash
VAULT-30 P2

Move the Universal Clipboard toggles into their own bottom sheet

0
All issues

Description

The three Universal Clipboard toggles take up a whole section of Settings, with a long footer. Move them into a dedicated bottom sheet.

Today: VaultSettingsView's universalClipboardSection shows three toggles, "Passwords", "One-time codes" and "Other", all with the same indigo icon. A four-line footer explains Universal Clipboard.

What to change:

  • Settings row: replace the section with a single Universal Clipboard row. Its value summarizes the state, for example "Off", "Codes only" or "On for all".
  • Sheet: the row opens a bottom sheet sized to fit, in the New Item picker's style: a title, a short explanation of what Universal Clipboard does, and the three toggles as cards on the sheet's glass.
  • Defaults: the toggles stay off by default (MANIFESTO.md C7).
  • Naming: name "Other" after what it actually covers.
  • Icons: give each toggle a distinct icon.

Tests: snapshot tests of the sheet, and of the row's summary for each combination, in light and dark mode.

Part of the Settings redesign (VAULT-24).

Linked issues

2
Relates to VAULT-24 P2 Improve the design of the Settings page Done
Relates to VAULT-38 P2 Make every copy in Vault follow the clipboard settings Done

Sub-issues

0

GitHub

0

No branches or pull requests linked.

Comments

1
Bradley

Fixed in https://github.com/badbundle/vault-app/pull/611 (merged as 7284c4df).

The new row and sheet:

  • Universal Clipboard is now a single row in the Clipboard section. It shows "On" or "Off", and opens a fitted bottom sheet in the New Item picker's style.
  • The sheet has a "One-Time Codes" card, off by default. Its subtitle follows the switch.

Toggles removed:

  • The "Passwords" and "Other" toggles are gone. Nothing in the app ever copied either kind of value, so they did nothing.
  • The old toggles' settings keys are marked never to be reused.
  • Copies made from the edit menu (notes, descriptions) skip the clipboard settings entirely. That's filed as VAULT-38, which then adds a Notes card to this sheet.

Shared pieces:

  • fittedSheet() is now a shared modifier, used by the picker and this sheet.
  • OptionCardToggle is new.

Tests: new snapshot tests of the sheet in light and dark, and of the row's "On"/"Off" summary.