trackslash
VAULT-18 P2

Show the header on the Auto-Backup page while it's locked

0
All issues

Description

While Auto-Backup is locked, the page shows only the "Locked" section and its Authenticate button. The same goes for "Authentication Failed" and the no-password state. The header only appears once you've authenticated. The Export page shows its header above the lock and looks much better for it, so do the same here.

AutoBackupView only shows headerSection in the .fetched case.

  • The live status header (viewModel.statusHeader) includes the destination folder's name and error details, so don't show it while the page is locked.
  • While locked, show a fixed header like Export's: "Auto-Backup" plus a line saying what it does.
  • Switch to the live status header once the page is unlocked.

Update the snapshot tests for the locked, failed and no-password states.

GitHub

0

No branches or pull requests linked.

Comments

1
Bradley

Fixed in https://github.com/badbundle/vault-app/pull/613 (merged as 2fdb0cc7).

While locked:

  • The Auto-Backup page always opens with a header, including when it's locked, after a failed authentication, or with no password.
  • In those states the header is fixed, in the Export page's style: "Auto-Backup" and one line on what it does.

Once unlocked: it becomes the live status header. That header is only built in the unlocked branch, so the folder name and error text can't show while locked.

Tests: the locked-state snapshots use a view model whose status names a folder and has an error, so any leak would change the reference images. There are new snapshots for the failed state and dark mode.